fix(target-size): pass for element that has nearby elements that are obscured #4422
+81
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
commented
Apr 22, 2024
| @@ -9,6 +9,7 @@ describe('target-size too many rects test', () => { | |||
| elementRef: true | |||
| }; | |||
| const context = { | |||
| include: '#incomplete', | |||
There was a problem hiding this comment.
On chrome for some reason it was failing with 2 incomplete instead of 1 where the other was the target h1 a (which is a mocha heading).
straker
commented
Apr 22, 2024
Comment on lines
+27
to
+32
| if (err.message.startsWith('splitRects')) { | ||
| this.data({ | ||
| messageKey: 'tooManyRects', | ||
| closestOffset: 0, | ||
| minOffset | ||
| }); |
There was a problem hiding this comment.
Decided that instead of failing this should just incomplete as well
straker
changed the title
WilcoFiers
approved these changes
Apr 23, 2024
Merged
WilcoFiers
added a commit
that referenced
this pull request
May 6, 2024
### [4.9.1](v4.9.0...v4.9.1) (2024-05-06) ### Bug Fixes - Prevent errors when loading axe in a page with prototype.js - **aria-allowed-attr:** allow meter role allowed aria-\* attributes on meter element ([#4435](#4435)) ([7ac6392](7ac6392)) - **aria-allowed-role:** add gridcell, separator, slider and treeitem to allowed roles of button element ([#4398](#4398)) ([4788bf8](4788bf8)) - **aria-roles:** correct abstract roles (types) for aria-roles([#4421](#4421)) - **aria-valid-attr-value:** aria-controls & aria-haspopup incomplete ([#4418](#4418)) - fix building axe-core translation files with region locales ([#4396](#4396)) ([5c318f3](5c318f3)), closes [#4388](#4388) - **invalidrole:** allow upper and mixed case role names ([#4358](#4358)) ([105016c](105016c)), closes [#2695](#2695) - **isVisibleOnScreen:** account for position: absolute elements inside overflow container ([#4405](#4405)) ([2940f6e](2940f6e)), closes [#4016](#4016) - **label-content-name-mismatch:** better dismiss and wysiwyg symbolic text characters ([#4402](#4402)) - **region:** Decorative images ignored by region rule ([#4412](#4412)) - **target-size:** ignore descendant elements in shadow dom ([#4410](#4410)) ([6091367](6091367)) - **target-size:** pass for element that has nearby elements that are obscured ([#4422](#4422)) ([3a90bb7](3a90bb7)), closes [#4387](#4387) This PR was opened by a robot 🤖 🎉 (And updated by @WilcoFiers )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to update how we handled the too many rects break early since it would return an empty array, which when looking at the lengths of the arrays in
getOffsetmade it difficult to know which case needed to be handled (returned empty due to too many rects or returned empty because there wasn't any visible rect). Talked to Wilco and we agreed that when we encountered too many rects we could throw and handle the error case in both checks.Closes: #4387